Add test for non local mac address. #9779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79ce7cf to
6bae875
Compare
|
rebased with changes to libcontainer |
| cmd := exec.Command(dockerBinary, "run", "--mac-address", "00:16:3E:08:00:50", "busybox", "ifconfig") | ||
| if out, _, err := runCommandWithOutput(cmd); err != nil { | ||
| t.Fatal(out, err) | ||
| } |
There was a problem hiding this comment.
Shouldn't this actually test that the output contains the MAC specified?
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com> (github: jfrazelle)
6bae875 to
98d5720
Compare
|
Updated! |
|
lol that output sure will be heinous in the error case, but it'll have all the important info 👍 |
|
LGTM |
|
Lol ya ALL THE INFO \o/ On Friday, December 26, 2014, Tianon Gravi notifications@github.com wrote:
|
jessfraz
pushed a commit
that referenced
this pull request
Dec 27, 2014
Add test for non local mac address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test will pass after docker-archive/libcontainer#310 is merged.
Closes #9771.
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle jess@docker.com (github: jfrazelle)