8000 Add master builds url to readme. by jessfraz · Pull Request #9639 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add master builds url to readme. #9639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2014
Merged

Add master builds url to readme. #9639

merged 1 commit into from
Dec 13, 2014

Conversation

jessfraz
Copy link
Contributor

Everyone know about & test master builds wooooo.

@tianon
Copy link
Member
tianon commented Dec 12, 2014

LGTM

1 similar comment
@crosbymichael
Copy link
Contributor

LGTM

@jessfraz
Copy link
Contributor Author

ping @fredlf @jamtur01 ?

@jamtur01
Copy link
Contributor

LGTM

@fredlf
Copy link
Contributor
fredlf commented Dec 13, 2014

It's not good web practice to make link text that's non-descriptive (i.e., "here"). Can you please recast so that "download master builds" is the link text?

More on this in the style guide.

@jessfraz
Add master builds url to readme.
1b104ce 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com> (github: jfrazelle)
@jessfraz jessfraz force-pushed the advertise-master-builds branch from 42353e2 to 1b104ce Compare December 13, 2014 00:27
@jessfraz
Copy link
Contributor Author

updated, sorry I'm going to read the style guide now, I feel like I always nuke it

@fredlf
Copy link
Contributor
fredlf commented Dec 13, 2014

LGTM

jessfraz pushed a commit that referenced this pull request Dec 13, 2014
Merge pull request #9639 from jfrazelle/advertise-master-builds
8ca28a3 
Add master builds url to readme.
@jessfraz jessfraz merged commit 8ca28a3 into moby:master Dec 13, 2014
@jessfraz jessfraz deleted the advertise-master-builds branch December 13, 2014 00:48
@SvenDowideit SvenDowideit mentioned this pull request Jan 27, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jessfraz @tianon @crosbymichael @jamtur01 @fredlf
0