LCOW: (Experimental) Require RS5+ builds #39108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
reviewed
Apr 18, 2019
Signed-off-by: John Howard <jhoward@microsoft.com>
6706629 to
e0b528f
Compare
|
LGTM! (not a maintainer) |
thaJeztah
reviewed
Apr 18, 2019
Signed-off-by: John Howard <jhoward@microsoft.com>
tonistiigi
approved these changes
Apr 18, 2019
Codecov Report
@@ Coverage Diff @@
## master #39108 +/- ##
=========================================
Coverage ?
8000
37.01%
=========================================
Files ? 612
Lines ? 45390
Branches ? 0
=========================================
Hits ? 16799
Misses ? 26307
Partials ? 2284 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard jhoward@microsoft.com
This moves the requirement for the experimental LCOW feature to at least RS5 builds of Windows, as per #33850 (comment).
The current LCOW solution uses the HCS "v1" schema. With the move to a containerd runtime, we are no longer planning on supporting LCOW support in the v1 schema in opengcs, and have been investing heavily in LCOW support through the v2 schema (driven via containerd, through hcsshim, and onto HCS; called from CRI, Kube, Docker,....).
Phase 2 of this will be to move the graphdriver remote filesystem access away from v1 as well.
Phase 3 will be the deprecation of the "local" libcontainerd runtime in favour of containerd which will only use the "v2" HCS schema.
@dmcgowan @crosbymichael @thaJeztah @jterry75 FYI.