builder-next: allow outputs configuration #38898
Conversation
| } | ||
| } | ||
|
|
||
| if exporterName == "moby" { |
There was a problem hiding this comment.
Wondering we should call it docker for BuildKit API compatibility
Or internal
There was a problem hiding this comment.
I don't want to call it docker cause that already means a different exporter. This value is completely invisible to user.
There was a problem hiding this comment.
It is also temporary. When containerd support lands, this should all go away.
There was a problem hiding this comment.
So, on client side, it is prohibited to set the output type to moby explicitly?
There was a problem hiding this comment.
Currently, you could use it to override options but I would never document it as a guaranteed behavior.
631fa6d to
aa00249
Compare
Codecov Report
@@ Coverage Diff @@
## master #38898 +/- ##
=========================================
Coverage ? 36.45%
=========================================
Files ? 614
Lines ? 45881
Branches ? 0
=========================================
Hits ? 16725
Misses ? 26869
Partials ? 2287 |
aa00249 to
7d62bb6
Compare
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
7d62bb6 to
768c6d7
Compare
Enables controlling exporter settings for build requests running in BuildKit. Only "local" exporter is currently supported as the others have a dependency on containerd contentstore and need to wait for #38043 .
The datatype is an array to support multiple exporters in the future. The implementation currently only accepts a single exporter.
The default behavior is to still export image into the image store.
@tiborvass @AkihiroSuda
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com