8000 Add Cache-Control headers to disable caching /_ping endpoint by thaJeztah · Pull Request #38569 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Cache-Control headers to disable caching /_ping endpoint #38569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2019
Merged

Add Cache-Control headers to disable caching /_ping endpoint #38569

merged 1 commit into from
Jan 31, 2019

Conversation

thaJeztah
Copy link
Member

The result of this endpoint should not be cached, so it's better to explicitly disable caching.

@thaJeztah
Add Cache-Control headers to disable caching /_ping endpoint
5f788fb 
The result of this endpoint should not be cached, so it's better to
explicitly disable caching.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

ping @cpuguy83 while I'm pinging you... here's another one 😂

@thaJeztah thaJeztah mentioned this pull request Jan 14, 2019
Merged
@codecov
Copy link
codecov bot commented Jan 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@beef00c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #38569   +/-   ##
=========================================
  Coverage          ?   36.65%           
=========================================
  Files             ?      608           
  Lines             ?    45173           
  Branches          ?        0           
=========================================
  Hits              ?    16560           
  Misses            ?    26332           
  Partials          ?     2281

Sorry, something went wrong.

@yongtang yongtang requested a review from cpuguy83 January 30, 2019 01:43
yongtang
yongtang approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member
@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yongtang yongtang merged commit 393838c into moby:master Jan 31, 2019
@thaJeztah thaJeztah deleted the forget_about_it branch January 31, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsong wsong wsong approved these changes

@yongtang yongtang yongtang approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@cpuguy83 cpuguy83 Awaiting requested review from cpuguy83

Assignees

@yongtang yongtang

Labels
area/api impact/api impact/changelog status/2-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thaJeztah @wsong @yongtang @AkihiroSuda @GordonTheTurtle
0