make.sh: leave around the generated version #11651
Conversation
For positerity (largely of packagers) lets leave around the generated version files that happen during build. They're already ignored in git, and recreated on every build. Signed-off-by: Vincent Batts <vbatts@redhat.com>
|
LGTM, this does help me build https://github.com/vbatts/docker-utils . |
|
ping @brahmaroutu |
|
This is essentially a revert of #10957, although that PR is sparse on the details of why it was opened (besides being "generally OK"). 😞 |
|
I feel like there was a specific problem this was solving, but I can't remember what it was. 😢 |
|
Generally, it is OK to leave them around. LGTM |
|
LGTM |
make.sh: leave around the generated version
|
does this need to be in 1.6.0 |
|
I'd like to include it so the version is present for posterity in packages.
|
|
It's interesting to me that RedHat can (and prefers to) include build
artifacts like this in their "source" representations. For Debian, the
focus is on the pristine, un-artifacted upstream source tarball (the "orig"
tarball), so build artifacts like this don't matter, especially since
they're trivially generated from the actual source code from upstream.
(Just as some extra context for why I'm confused about this being good for
the packaging.)
|
|
@tianon it is not to be confused with "orig" source, but like the btrfs
|
|
Ahh, that makes more sense.
|
For positerity (largely of packagers) lets leave around the generated
version files that happen during build.
They're already ignored in git, and recreated on every build.
ping @tianon and @lsm5
Signed-off-by: Vincent Batts vbatts@redhat.com