8000 Check nil volume on mount init by cpuguy83 · Pull Request #10926 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Check nil volume on mount init #10926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2015
Merged

Check nil volume on mount init #10926

merged 1 commit into from
Feb 23, 2015

Conversation

cpuguy83
Copy link
Member

Fixes #10685 panic in some cases.

@cpuguy83
Check nil volume on mount init
7122b66 
Fixes moby#10685 panic in some cases.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83 cpuguy83 added this to the 1.5.1 milestone Feb 21, 2015
@LK4D4
Copy link
Contributor
LK4D4 commented Feb 22, 2015

LGTM

@jessfraz
Copy link
Contributor

LGTM but just curious how it would be nil

jessfraz pushed a commit that referenced this pull request Feb 23, 2015
Merge pull request #10926 from cpuguy83/10685_check_nil_volume
ae9001f 
Check nil volume on mount init
@jessfraz jessfraz merged commit ae9001f into moby:master Feb 23, 2015
@cpuguy83
Copy link
Member Author

I think because the /proc/mounts is the same, but the actual resolved path is different after every daemon restart.

@SvenDowideit SvenDowideit mentioned this pull request Feb 26, 2015
Closed
@jessfraz jessfraz modified the milestones: 1.5.1, 1.6.0 Mar 16, 2015
@cpuguy83 cpuguy83 deleted the 10685_check_nil_volume branch September 20, 2017 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Docker 1.4.1 panics when starting container in docker/volumes/volume.go:78
5 participants
@cpuguy83 @LK4D4 @jessfraz @dmp42 @GordonTheTurtle
0