Add Steve and Mary as docs maintainers #10866
Conversation
Signed-off-by: Solomon Hykes <solomon@docker.com>
|
Can you please sign your commits following these rules: https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit: $ git clone -b "shykes-new-docs-maintainers" git@github.com:docker/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f |
392e3c3 to
ed1b491
Compare
|
Damn you gordon! |
ed1b491 to
0d41c6a
Compare
|
LGTM |
|
|
||
| [people.mary] | ||
| Name = "Mary Anthony" | ||
| Email = "mary.anthony@docker.com" |
There was a problem hiding this comment.
Shouldn't there be a GitHub handle?
There was a problem hiding this comment.
Also; the list should be in alphabetical order 😄
There was a problem hiding this comment.
@thaJeztah I will fix in followup PR
There was a problem hiding this comment.
@jfrazelle Want me to do that? or would it be faster if you did it? :)
There was a problem hiding this comment.
I already had a patch fixing something in it with tomlv too, so I just
added it to that, pinged you on it too :)
On Thu, Feb 19, 2015 at 11:45 AM, Sebastiaan van Stijn <
notifications@github.com> wrote:
In MAINTAINERS
#10866 (comment):@@ -588,3 +590,7 @@ made through a pull request.
Name = "Vishnu Kannan"
Email = "vishnuk@google.com"
GitHub = "vishh"
+
- [people.mary]
- Name = "Mary Anthony"
- Email = "mary.anthony@docker.com"
@jfrazelle https://github.com/jfrazelle Want me to do that? or would it
be faster if you did it? :)—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/10866/files#r25018358.
|
(y, need to add @moxiegirl's GH handle) mmm, need to find the docs subsystem rules - I presume we don't want to go back to needing 3 LGTM's |
|
@SvenDowideit You can create a DOCS-BOT and add it as maintainer. Everytime you LGTM, it'll automatically repeat you 😸 |
|
lgtm |
|
Awesome! LGTM. |
Add Steve and Mary as docs maintainers
Add Steve and Mary as docs maintainers (cherry picked from commit 009efd0)
No description provided.