8000 Update IPv6 docs with modern `ip` command use + `sysctl` by estesp · Pull Request #10751 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update IPv6 docs with modern ip command use + sysctl #10751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2015
Merged

Update IPv6 docs with modern ip command use + sysctl #10751

merged 1 commit into from
Feb 19, 2015

Conversation

estesp
Copy link
Contributor
@estesp estesp commented Feb 12, 2015

Fixes: #10701

Updates the IPv6 documentation and images to reflect the more modern
ip -6 command set versus route and ifconfig. Also removes the
use of the special 2002: address range as that is reserved for 6to4
addressing.

Docker-DCO-1.1-Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com (github: estesp)

@LK4D4
Copy link
Contributor
LK4D4 commented Feb 12, 2015

nice, thanks

@SvenDowideit
Copy link
Contributor

mmm, I'll have to test a few things and distros - though I think - yay :)

@estesp
Copy link
Contributor Author
estesp commented Feb 13, 2015

@SvenDowideit definitely validation would be good.. seems OK on Fedora 21 and Ubuntu 14.10 from the checking I did today. Also, I don't have any good SVG tools and I was not happy that gliffy export-to-SVG seemed to generate larger files than the previous ones in the tree. Only one has a significantly different canvas size, which shouldn't matter as SVG is only the vectors and text--so not sure what was done last time, but let me know if I need to use another tool to simplify them.

@thaJeztah thaJeztah mentioned this pull request Feb 14, 2015
Closed
@thaJeztah
Copy link
Member

I asked the reporter of #10701 if he could have a look at this PR as well to see if this resolves his issue, but there still are some issues, see #10701 (comment)

(Sorry that this caused the discussion to be spread over two locations now)

@MalteJ
Copy link
Contributor
MalteJ commented Feb 16, 2015

@estesp thanks for this PR.
+1 for the ip command.
But we should use the documentation IPv6 address range 2001:db8::/32 as defined by RFC3849 for our examples. Unfortunately the addresses in the graphs will get bigger. But I think we should use the reserved documentation address space. I mean, it is there for a reason.

@estesp estesp force-pushed the 10701-update-ipv6-docs branch from fd7dd70 to 8abb7ac Compare February 16, 2015 23:23
@estesp
Copy link
Contributor Author
estesp commented Feb 16, 2015

@MalteJ PR is updated using only subnets from doc prefix address space. I think I got everything right, but head starts swimming trying to keep all the subnets straight in the diagram and text :)

Edit: Hmm..those are actually /48's? 2001:db8:1::, 2001:db8:2::, 2001:db8:3:: ; /64s would have an extra 0 (e.g. 2001:db8:0:1::/64)? Is that right?

@estesp estesp force-pushed the 10701-update-ipv6-docs branch from 975fd7d to 71e98e4 Compare February 19, 2015 16:05
@estesp
Update IPv6 docs with modern ip co 8000 mmand use + sysctl
95668ed 
Fixes: moby#10701

Updates the IPv6 documentation and images to reflect the more modern
`ip -6` command set versus `route` and `ifconfig`.  Also removes the
use of the special 2002: address range as that is reserved for 6to4
addressing, as well as use of any public address range and re-works the
switched routing example to use 3 subnets of the documentation IPv6
prefix range.

Also conformed all use of addresses to the same doc range per @MalteJ's
commit.

Docker-DCO-1.1-Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com> (github: estesp)
Signed-off-by: Malte Janduda <mail@janduda.net>
@estesp estesp force-pushed the 10701-update-ipv6-docs branch from 71e98e4 to 95668ed Compare February 19, 2015 17:21
@estesp
Copy link
Contributor Author
estesp commented Feb 19, 2015

@SvenDowideit this PR has been updated to re-align all addresses around the doc prefix range, as well as all images. @MalteJ has provided additional updates which I've merged in. Please review when you are able. Thanks!

@jessfraz
Copy link
Contributor

LGTM

@jessfraz
Copy link
Contributor

ping @SvenDowideit @MalteJ

@MalteJ
Copy link
Contributor
MalteJ commented Feb 19, 2015

LGTM
(that's my first lgtm 😄)

@jessfraz
Copy link
Contributor

thanks!

jessfraz pushed a commit that referenced this pull request Feb 19, 2015
Merge pull request #10751 from estesp/10701-update-ipv6-docs
72e6613 
Update IPv6 docs with modern `ip` command use + `sysctl`
@jessfraz jessfraz merged commit 72e6613 into moby:master Feb 19, 2015
@SvenDowideit SvenDowideit mentioned this pull request Feb 26, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
57F4 No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc uses outdated commands
8 participants
@estesp @LK4D4 @SvenDowideit @thaJeztah @MalteJ @jessfraz @dmp42 @GordonTheTurtle
0