TestBuildAddTarXz(Gz): call xz with '-k' due to bug #10755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestBuildAddTarXz/TestBuildAddTarXzGz make exec calls like 'cd %SOME_TEMP_DIR%; xz test.gz' but this fails when called from integration-cli tests (doesn't fail from msys or cmd shell). It fails with error: "xz: test.tar: Cannot remove: Permission denied." Proposing workaround of using the `xz --keep` argument since keeping test.tar is harmless and it's already in os.TempDir(). Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
|
@jfrazelle this fixed the tests:
https://jenkins.dockerproject.com/job/Windows-PRs/32/console
😂 |
|
LGTM |
|
:D |
|
LGTM |
tiborvass
added a commit
that referenced
this pull request
Feb 13, 2015
…XzGz-fix TestBuildAddTarXz(Gz): call xz with '-k' due to bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestBuildAddTarXz/TestBuildAddTarXzGz make exec calls like
'cd %SOME_TEMP_DIR%; xz test.gz' but this fails when called
from integration-cli tests (doesn't fail from msys or cmd shell)
when executed on Windows.
It fails with error: "xz: test.tar: Cannot remove: Permission denied."
Proposing workaround of using the
xz --keepargument since keepingtest.tar is harmless and it's already in os.TempDir().
If anybody volunteers to see what's going on, console log is here:
https://jenkins.dockerproject.com/job/Windows-PRs/31/console
I can repro this as well but can't exactly figure out why it happens
only when it's called via
go test.Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
Label:
#windowsCc: @jfrazelle @unclejack @tiborvass