8000 Change verbose builder out back to attach by LK4D4 · Pull Request #10573 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change verbose builder out back to attach #10573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2015
Merged

Change verbose builder out back to attach #10573

merged 1 commit into from
Feb 6, 2015

Conversation

LK4D4
Copy link
Contributor
@LK4D4 LK4D4 commented Feb 4, 2015

This is sort of "revert" of #8415. There is some problems with using
logs:

  • Non-live progressbars
  • Races when you can try to get logs before it was written(there was
    occasional errors in tests)

@LK4D4
Change verbose builder out back to attach
1095d5e 
This is sort of "revert" of #8415. There is some problems with using
logs:
* Non-live progressbars
* Races when you can try to get logs before it was written(there was
  occasional errors in tests)

Signed-off-by: Alexander Morozov <lk4d4@docker.com>
@jessfraz
Copy link
Contributor
jessfraz commented Feb 5, 2015

LGTM

1 similar comment
@crosbymichael
Copy link
Contributor

LGTM

crosbymichael added a commit that referenced this pull request Feb 6, 2015
@crosbymichael
Merge pull request #10573 from LK4D4/return_attach_to_builder
e345fe5 
Change verbose builder out back to attach
@crosbymichael crosbymichael merged commit e345fe5 into moby:master Feb 6, 2015
@crosbymichael crosbymichael added this to the 1.6.0 milestone Feb 6, 2015
@LK4D4 LK4D4 deleted the return_attach_to_builder branch February 6, 2015 22:37
@SvenDowideit SvenDowideit mentioned this pull request Feb 9, 2015
Closed
@SvenDowideit SvenDowideit mentioned this pull request Feb 26, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@LK4D4 @jessfraz @crosbymichael
0