8000 Fix compilation on Go 1.3.3 by jessfraz · Pull Request #10565 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix compilation on Go 1.3.3 #10565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2015
Merged

Fix compilation on Go 1.3.3 #10565

merged 1 commit into from
Feb 4, 2015

Conversation

jessfraz
Copy link
Contributor
@jessfraz jessfraz commented Feb 4, 2015

No description provided.

@jessfraz
Fix compilation on Go 1.3.3
8000
4855612 
Docker-DCO-1.1-Signed-off-by: Jessie Frazelle <jess@docker.com> (github: jfrazelle)
@jessfraz
Copy link
Contributor Author
jessfraz commented Feb 4, 2015

you can see it compilesd on 1.3.3 here https://jenkins.dockerproject.com/job/Docker-Go1.3.3/label=ubuntu-btrfs/120/console

@tianon
Copy link
Member
tianon commented Feb 4, 2015

👍

Looks like we should add a Go 1.3 builder to our PRs? 👼

@jessfraz
Copy link
Contributor Author
jessfraz commented Feb 4, 2015

well we have the checks on master unsure just how muchhhhhh infra we can
build out for the amount of prs we get a day

On Wed, Feb 4, 2015 at 1:52 PM, Tianon Gravi notifications@github.com
wrote:

[image: 👍]

Looks like we should add a Go 1.3 builder to our PRs? [image: 👼]

—
Reply to this email directly or view it on GitHub
#10565 (comment).

@tianon
Copy link
Member
tianon commented Feb 4, 2015

@tiborvass
Copy link
Contributor

LGTM

1 similar comment
@LK4D4
Copy link
Contributor
LK4D4 commented Feb 4, 2015

LGTM

LK4D4 added a commit that referenced this pull request Feb 4, 2015
@LK4D4
Merge pull request #10565 from jfrazelle/fix-range
7cc9858 
Fix compilation on Go 1.3.3
@LK4D4 LK4D4 merged commit 7cc9858 into moby:master Feb 4, 2015
@SvenDowideit SvenDowideit mentioned this pull request Feb 9, 2015
Closed
@jessfraz jessfraz deleted the fix-range branch February 17, 2015 17:51
@SvenDowideit SvenDowideit mentioned this pull request Feb 26, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jessfraz @tianon @tiborvass @LK4D4
0