Documentation on boolean flags is wrong #10517 #10546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| For example, if you do call `docker run -d`, that sets the value to `true`, so | ||
| your container **will** run in "detached" mode, in the background. | ||
|
|
||
| Options which a defaulted to `true` (i.e., `docker build --rm=true`) can only |
There was a problem hiding this comment.
Perhaps Options which default to... ?
413d0e7 to
3aa625e
Compare
|
LGTM |
|
LGTM thanks for the fix |
| so `docker run -d` **will** run in "detached" mode, | ||
| in the background. Other boolean options are similar – specifying them | ||
| will set the value to the opposite of the default value. | ||
| Boolean options look like `-d=false`. The value you see in the help text, is the |
There was a problem hiding this comment.
Omit comma after "text".
Maybe change "look like" to "take the form".
|
A couple small copy edits. Otherwise, LGTM |
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
3aa625e to
1e6e683
Compare
jessfraz
pushed a commit
that referenced
this pull request
Feb 6, 2015
Documentation on boolean flags is wrong #10517
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sven Dowideit SvenDowideit@home.org.au
closes ##10517