8000 Defer creation of trust key file until needed by dmcgowan · Pull Request #10446 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Defer creation of trust key file until needed #10446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2015

Conversation

dmcgowan
Copy link
Member

Currently push is the only operation making uses of the key, this change defers creation until the push operation is called.

Fixes #10442

@LK4D4
Copy link
Contributor
LK4D4 commented Jan 29, 2015

I think we can write test for this.

@LK4D4
Copy link
Contributor
LK4D4 commented Jan 29, 2015

@dmcgowan Integration tests failed to compile

Fixes moby#10442

Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
@dmcgowan dmcgowan force-pushed the defer-key-file-creation branch from 496bf0d to 0eed1f4 Compare January 29, 2015 21:46
@crosbymichael crosbymichael added this to the 1.5.0 milestone Jan 29, 2015
@crosbymichael
Copy link
Contributor

LGTM

2 similar comments
@tiborvass
Copy link
Contributor

LGTM

@jessfraz
Copy link
Contributor

LGTM

jessfraz pushed a commit that referenced this pull request Jan 29, 2015
Defer creation of trust key file until needed
@jessfraz jessfraz merged commit d748ec3 into moby:master Jan 29, 2015
@dmcgowan dmcgowan deleted the defer-key-file-creation branch June 15, 2016 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker client requires write permission to $HOME
5 participants
0