8000 Add the list of possible values for --log-level to help text by duglin · Pull Request #10124 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add the list of possible values for --log-level to help text #10124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2015
Merged

Add the list of possible values for --log-level to help text #10124

merged 1 commit into from
Jan 20, 2015

Conversation

duglin
Copy link
Contributor
@duglin duglin commented Jan 15, 2015

Closes #10034

Signed-off-by: Doug Davis dug@us.ibm.com

Add the list of possible values for --log-level to help text
ed13110 
Closes moby#10034

Signed-off-by: Doug Davis <dug@us.ibm.com>
@duglin duglin mentioned this pull request Jan 15, 2015
Closed
@SvenDowideit
Copy link
Contributor

LGTM - @fredlf @jamtur01 @jfrazelle @tiborvass

@SvenDowideit
Copy link
Contributor

mmm, will this need bash and fish prompting changes too?

@jamtur01
Copy link
Contributor

LGTM

@tiborvass tiborvass added this to the 1.5.0 milestone Jan 16, 2015
@tiborvass
Copy link
Contributor

@duglin do you think we could update the shell completions accordingly like Sven said?
But if you prefer we do this in another PR i'm fine with that too.

@duglin
Copy link
Contributor Author
duglin commented Jan 16, 2015

@tiborvass @SvenDowideit yep was starting to look at the completion stuff last night - never played with that stuff before so there's a learning curve for me...

@thaJeztah
Copy link
Member

@duglin For fish, there looks to be a script to update the completions (https://github.com/docker/docker/blob/master/contrib/completion/fish/docker.fish#L4). Do we currently have completion for daemon flags in bash? I glanced over the bash completion yesterday, but didn't find anything related to that.

Perhaps @albers is willing to assist? He made some awesome changes to the bash completions, so instead of you having to figure out how they work, maybe he can help?

@albers
Copy link
Member
albers commented Jan 17, 2015

I will include this in my next chunk of additions to bash completion, which will be due soon. Thanks for pointing me at it.

@thaJeztah
Copy link
Member

Thanks, @albers!

@duglin that leaves fish and zsh. I can have a quick go at fish completions for this if you want (they don't look complicated)?

@icecrime
Copy link
Contributor

LGTM: I'll update fish completion once this is merged (top-level flags are not currently part of the bash and zsh completions).

@albers
Copy link
Member
albers commented Jan 19, 2015

I'm already working on the deamon flags in bash completion

@icecrime
Copy link
Contributor

@albers Perfect thanks!

@crosbymichael
Copy link
Contributor

LGTM

crosbymichael added a commit that referenced this pull request Jan 20, 2015
@crosbymichael
Merge pull request #10124 from duglin/Issue10034
1efc940 
Add the list of possible values for --log-level to help text
@crosbymichael crosbymichael merged commit 1efc940 into moby:master Jan 20, 2015
@albers albers mentioned this pull request Jan 20, 2015
Merged
@albers
Copy link
Member
albers commented Jan 20, 2015

@thaJeztah @icecrime bash completion for daemon flags is completed, see #10219.

@duglin
Copy link
Contributor Author
duglin commented Jan 20, 2015

@albers thanks a ton!

@duglin duglin deleted the Issue10034 branch January 22, 2015 22:21
@SvenDowideit SvenDowideit mentioned this pull request Jan 27, 2015
Merged
@thaJeztah thaJeztah mentioned this pull request Sep 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Docker --log-level implemented, but not documented
8 participants
@duglin @SvenDowideit @jamtur01 @tiborvass @thaJeztah @albers @icecrime @crosbymichael
0