8000 Fix some Windows integration tests by icecrime · Pull Request #10106 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix some Windows integration tests #10106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2015
Merged

Fix some Windows integration tests #10106

merged 1 commit into from
Jan 15, 2015

Conversation

icecrime
Copy link
Contributor

Fix tests making the assumption that the daemon can be accessed through unix:///var/run/docker.sock.

Take DOCKER_TEST_HOST into account
e1ef334 
Tests no longer make the assumption that the daemon can be accessed
through unix:///var/run/docker.sock.

Signed-off-by: Arnaud Porterie <arnaud.porterie@docker.com>
@icecrime icecrime force-pushed the win_integration_tests branch from 1c731e6 to e1ef334 Compare January 15, 2015 00:14
@jessfraz
Copy link
Contributor

wooohoooo watch it goooo https://jenkins.dockerproject.com/job/Windows%20PRs/label=windows/3/console

@tianon
Copy link
Member
tianon commented Jan 15, 2015

👍

@ahmetb
Copy link
Contributor
ahmetb commented Jan 15, 2015

🎉 whoa, that's cool. LGTM. :shipit: (label: windows pls)

cc: @sachin-jayant-joshi

@icecrime
Copy link
Contributor Author

I think we can iterate on this PR rather than submit test by test: you can send PRs to icecrime/win_integrations_tests if you want to participate.

@jessfraz
Copy link
Contributor

LGTM

@crosbymichael
Copy link
Contributor

LGTM

crosbymichael added a commit that referenced this pull request Jan 15, 2015
@crosbymichael
Merge pull request #10106 from icecrime/win_integration_tests
c126a23 
Fix some Windows integration tests
@crosbymichael crosbymichael merged commit c126a23 into moby:master Jan 15, 2015
@tianon
Copy link
Member
tianon commented Jan 15, 2015

Lots of smaller PRs FTW! :)

@icecrime
Copy link
Contributor Author

Apparently... :-)

@SvenDowideit SvenDowideit mentioned this pull request Jan 27, 2015
Merged
@icecrime icecrime deleted the win_integration_tests branch July 15, 2015 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
platform/windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@icecrime @jessfraz @tianon @ahmetb @crosbymichael
319E
0