8000 Test for restarting count by LK4D4 · Pull Request #10075 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test for restarting count #10075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2015
Merged

Test for restarting count #10075

merged 1 commit into from
Jan 14, 2015

Conversation

LK4D4
Copy link
Contributor
@LK4D4 LK4D4 commented Jan 13, 2015

This test is for #10058
ping @jfrazelle

@jessfraz
Copy link
Contributor

cool!

jessfraz
jessfraz reviewed Jan 13, 2015
View reviewed changes
integration-cli/docker_cli_run_test.go
}
if len(lines) != 4 {
t.Fatalf("Container was restarted %d times, expected %d", len(lines)-1, 3)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a log()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also its failing locally :(

@icecrime
Copy link
Contributor

I think this is could be made much simpler thanks to #9621:

$ docker inspect -f '{{.RestartCount}}' 3d4defe2061
3

@LK4D4
Copy link
Contributor Author
LK4D4 commented Jan 13, 2015

@jfrazelle @icecrime PTAL

@icecrime
Copy link
Contributor

LGTM

On Tuesday, January 13, 2015, Alexander Morozov notifications@github.com
wrote:

@jfrazelle https://github.com/jfrazelle @icecrime
https://github.com/icecrime PTAL

—
Reply to this email directly or view it on GitHub
#10075 (comment).

Arnaud Porterie

@jessfraz
Copy link
Contributor

kewllll waiting on drone

@jessfraz
Copy link
Contributor

😢

@jessfraz
Copy link
Contributor

hmm it works locally

@LK4D4
Copy link
Contributor Author
LK4D4 commented Jan 14, 2015

Haha, it's a race, I think I know solution

@LK4D4
Test for restarting count
79d3036 
This test is for #10058
Signed-off-by: Alexander Morozov <lk4d4@docker.com>
@LK4D4
Copy link
Contributor Author
LK4D4 commented Jan 14, 2015

@icecrime @jfrazelle I think know there is no place for race

@icecrime
Copy link
Contributor

Hehe nice :-) LGTM

@jessfraz
Copy link
Contributor

LGTM

jessfraz pushed a commit that referenced this pull request Jan 14, 2015
Merge pull request #10075 from LK4D4/test_for_maxcount
5136b11 
Test for restarting count
@jessfraz jessfraz merged commit 5136b11 into moby:master Jan 14, 2015
@LK4D4 LK4D4 deleted the test_for_maxcount branch January 14, 2015 18:01
@SvenDowideit SvenDowideit mentioned this pull request Jan 27, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LK4D4 @jessfraz @icecrime
0