Feature/network info #120
Open
Feature/network info #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add NetworkInfo interface with type, connection status, network name, and signal strength - Implement Android network info using ping connectivity test - Implement iOS network info using go-ios info command with fallback - Implement iPhone Simulator network info with host connectivity assumption - Register mobile_get_network_info MCP tool for cross-platform network status - Add comprehensive error handling and logging for network operations
- Add comprehensive network info testing to validate return types and values - Test network info structure (type, isConnected, optional fields) - Validate network type enum values (wifi, cellular, none, unknown) - Ensure cross-platform compatibility and consistent behavior - Tests pass successfully on Android and iPhone Simulator
- Move local helper functions to private class methods - Consistent with existing patterns like isAscii(), getUiAutomatorDump() - Applied across Android, iOS, and iPhone Simulator implementations - No functional changes, only style alignment
- Replace simctl spawn ping with direct host ping command - iOS simulators use host network, so check host connectivity directly - Fixes false negative where simulator showed 'none' despite working internet - Now correctly detects wifi/connected state matching actual connectivity - Network info feature complete across all platforms
|
@eamon831 this is an excellent pull request! thank you so much!! 🤯 💯 . I'll review the code later today/tomorrow and after manually testing, let's merge this!!! thank you!!! |
gmegidish
reviewed
Jun 27, 2025
| @@ -310,14 +349,117 @@ export class AndroidRobot implements Robot { | |||
|
|
|||
| // disable auto-rotation prior to setting the orientation | |||
| this.adb("shell", "settings", "put", "system", "accelerometer_rotation", "0"); | |||
| this.adb("shell", "content", "insert", "--uri", "content://settings/system", "--bind", "name:s:user_rotation", "--bind", `value:i:${orientationValue}`); | |||
| this.adb( | |||
There was a problem hiding this comment.
why is most of the PR just re-formatting :(
why is it modifying these lines?
gmegidish
reviewed
Jun 27, 2025
| } | ||
| } | ||
|
|
||
| private async getWifiInfo() { |
There was a problem hiding this comment.
the code is copy-pasted entirely from android.ts, no?
gmegidish
reviewed
Jun 27, 2025
| } | ||
| } | ||
|
|
||
| private parseWifiInfo(info: string) { |
There was a problem hiding this comment.
where is the response type?
gmegidish
reviewed
Jun 27, 2025
| assert.ok(typeof networkInfo.isConnected === "boolean"); | ||
|
|
||
| // type should be one of the valid network types | ||
| const validTypes = ["wifi", "cellular", "none", "unknown"]; |
There was a problem hiding this comment.
shouldn't this test assert not only the type? cause these should be enforced by typescript. but maybe assert that all simulators return a specific type (is it wifi?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Overview
Adds comprehensive network connectivity detection to mobile-mcp, providing real-time network information across Android devices, iOS devices, and iOS simulators through a unified
getNetworkInfo()API.✨ Features Added
NetworkInfointerfacemobile_get_network_infocommand🧪 Use Cases
🔧 Implementation Details
Android Implementation:
dumpsys connectivityiOS Device Implementation:
go-ios wifi infoiOS Simulator Implementation:
📊 API Interface
🧪 Testing
💡 Technical Highlights
🔧 Usage Examples
🛠️ Breaking Changes
None - This is a new feature addition.
📋 Checklist
Ready for review and merge! Particularly useful for testing applications against various internet connectivity scenarios. Fully tested and validated with Cursor AI development environment. 🚀