8000 Fix typo in Javadocs of MockedConstruction by hotire · Pull Request #2180 · mockito/mockito · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix typo in Javadocs of MockedConstruction #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2021
Merged

Fix typo in Javadocs of MockedConstruction #2180

merged 1 commit into from
Jan 17, 2021

Conversation

hotire
Copy link
Contributor
@hotire hotire commented Jan 17, 2021 •
edited
Loading

Hi 🖐

I noted this while reading the Javadocs of MockedConstruction.

They were referring to static method and out of scope variable. It isn't quite easy to grasp in this context.

I think it's just a copy-paste mistake.

@codecov-io
Copy link
codecov-io commented Jan 17, 2021 •
edited
Loading

Codecov Report

Merging #2180 (f0a1d8a) into release/3.x (7b940bc) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/3.x    #2180      +/-   ##
=================================================
+ Coverage          84.87%   84.90%   +0.02%     
  Complexity          2722     2722              
=================================================
  Files                325      325              
  Lines               8280     8280              
  Branches             989      989              
=================================================
+ Hits                7028     7030       +2     
  Misses               981      981              
+ Partials             271      269       -2
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/mockito/Mockito.java 91.02% <ø> (ø) 55.00 <0.00> (ø)
...to/internal/util/concurrent/WeakConcurrentMap.java 41.48% <0.00%> (+2.12%) 11.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b940bc...f0a1d8a. Read the comment docs.

TimvdLippe
TimvdLippe approved these changes Jan 17, 2021
View reviewed changes
Copy link
Contributor
@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@TimvdLippe TimvdLippe merged commit 0630886 into mockito:release/3.x Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimvdLippe TimvdLippe TimvdLippe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hotire @codecov-io @TimvdLippe
0