normalize setters and getters #3058
Labels
semver-minor
implementation requires increase of "minor" version number; "features"
status: accepting prs
Mocha can use your help with this one!
type: chore
generally involving deps, tooling, configuration, etc.
Comments
makepanic
added a commit
to makepanic/mocha
that referenced
this issue
Oct 9, 2017
makepanic
added a commit
to makepanic/mocha
that referenced
this issue
Oct 9, 2017
makepanic
added a commit
to makepanic/mocha
that referenced
this issue
Oct 16, 2017
makepanic
added a commit
to makepanic/mocha
that referenced
this issue
Oct 18, 2017
boneskull
pushed a commit
that referenced
this issue
Oct 27, 2017
OmgImAlexis
referenced
this issue
in agenda/agenda
Jun 26, 2018
This Pull Request updates dependency [mocha](https://github.com/mochajs/mocha) from `v4.0.1` to `v4.1.0` <details> <summary>Release Notes</summary> ### [`v4.1.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#​410--2017-12-28) [Compare Source](mochajs/mocha@v4.0.1...v4.1.0) This is mainly a "housekeeping" release. Welcome [@​Bamieh] and [@​xxczaki] to the team! #### 🐛 Fixes - [#​2661]: `progress` reporter now accepts reporter options ([@​canoztokmak]) - [#​3142]: `xit` in `bdd` interface now properly returns its `Test` object ([@​Bamieh]) - [#​3075]: Diffs now computed eagerly to avoid misinformation when reported ([@​abrady0]) - [#​2745]: `--help` will now help you even if you have a `mocha.opts` ([@​Zarel]) #### 🎉 Enhancements - [#​2514]: The `--no-diff` flag will completely disable diff output ([@​CapacitorSet]) - [#​3058]: All "setters" in Mocha's API are now also "getters" if called without arguments ([@​makepanic]) #### 📖 Documentation - [#​3170]: Optimization and site speed improvements ([@​Munter]) - [#​2987]: Moved the old [site repo](https://github.com/mochajs/mochajs.github.io) into the main repo under `docs/` ([@​boneskull]) - [#​2896]: Add [maintainer guide](https://github.com/mochajs/mocha/blob/master/MAINTAINERS.md) ([@​boneskull]) - Various fixes and updates ([@​xxczaki], [@​maty21], [@​leedm777]) #### 🔩 Other - Test improvements and fixes ([@​eugenet8k], [@​ngeor], [@​38elements], [@​Gerhut], [@​ScottFreeCode], [@​boneskull]) - Refactoring and cruft excision ([@​38elements], [@​Bamieh], [@​finnigantime], [@​boneskull]) [#​2661]: `https://github.com/mochajs/mocha/issues/2661` [#​3142]: `https://github.com/mochajs/mocha/issues/3142` [#​3075]: `https://github.com/mochajs/mocha/pull/3075` [#​2745]: `https://github.com/mochajs/mocha/issues/2745` [#​2514]: `https://github.com/mochajs/mocha/issues/2514` [#​3058]: `https://github.com/mochajs/mocha/issues/3058` [#​3170]: `https://github.com/mochajs/mocha/pull/3170` [#​2987]: `https://github.com/mochajs/mocha/issues/2987` [#​2896]: `https://github.com/mochajs/mocha/issues/2896` [@​canoztokmak]: https://github.com/canoztokmak [@​Bamieh]: https://github.com/Bamieh [@​abrady0]: https://github.com/abrady0 [@​Zarel]: https://github.com/Zarel [@​CapacitorSet]: https://github.com/CapacitorSet [@​xxczaki]: https://github.com/xxczaki [@​maty21]: https://github.com/maty21 [@​leedm777]: https://github.com/leedm777 [@​eugenet8k]: https://github.com/eugenet8k [@​38elements]: https://github.com/38elements [@​Gerhut]: https://github.com/Gerhut [@​finnigantime]: https://github.com/finnigantime --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
This was referenced Sep 22, 2018
Closed
Closed
This was referenced Sep 23, 2018
Closed
This was referenced Oct 2, 2018
This was referenced Oct 31, 2018
This was referenced Nov 12, 2018
This was referenced Dec 1, 2018
This was referenced Dec 8, 2018
This was referenced Dec 23, 2018
sgilroy
pushed a commit
to TwineHealth/mocha
that referenced
this issue
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The main classes (
Runnable,Test,Context,Suite,Mocha, etc.) have these setter/getter functions, e.g.Runnable#timeout(). Not all of these, however, implement the "getter" part, where it's supposed to just return the value if it receives no arguments.Furthermore, there are some methods that might check if the first argument is
undefined; they need to check length ofargumentsinstead, becauseundefinedorvoid 0is a valid argument.The text was updated successfully, but these errors were encountered: