negate all booleans #102
Merged
negate all booleans #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this enables two nice things:
1)
"scripts": {
"abc": "mycli --foo"
}
pnpm abc // foo: true
pnpm abc --no-foo // foo: false
2)
now, if you do `foo: z.boolean().optional()` as an option:
mycli --foo // {foo: true}
mycli --no-foo // {foo: false}
mycli // {} (no foo property at all)
and your cli can add custom behaviour when options.foo === undefined e.g. prompting for the user to decide proactively
|
@AmanVarshney01 pkg-pr-new ran too early to comment on the PR but you can try this with: |
|
@mmkal Thanks! Works great 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4DB2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this enables two nice things:
"scripts": {
"abc": "mycli --foo"
}
pnpm abc // {foo: true}
pnpm abc --no-foo // {foo: false}
now, if you do
foo: z.boolean().optional()as an option:mycli --foo // {foo: true}
mycli --no-foo // {foo: false}
mycli // {} (no foo property at all)
and your cli can add custom behaviour when options.foo === undefined e.g. prompting for the user to decide if they want
fooor not, definitivelycc @AmanVarshney01