8000 include 4th response for SR,A,Auto in the check by vimalnakum · Pull Request #334 · mlcommons/power-dev · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

include 4th response for SR,A,Auto in the check #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

vimalnakum
Copy link
Contributor

The compliance check.py currently checks for Power meter response SR,A,Auto as 3rd response. Sometimes that response does come as 4th reponse and the check fails. This happens with new PTD 1.11 and with new power code. This change would check for both 3rd and 4th response and see if Auto field is there.
Verified with ptd logs from sima SUT.

@vimalnakum vimalnakum requested a review from a team as a code owner February 20, 2025 21:39
Copy link
github-actions bot commented Feb 20, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor
@araghun araghun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified by Takahiro and others

@araghun araghun merged commit c4b3ad8 into mlcommons:master Feb 21, 2025
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0