8000 Fix a typo and Markdown heading levels by bact · Pull Request #802 · mlcommons/croissant · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix a typo and Markdown heading levels #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 7, 2025
Merged

Fix a typo and Markdown heading levels #802

merged 6 commits into from
May 7, 2025

Conversation

bact
Copy link
Contributor
@bact bact commented Jan 29, 2025 •
edited
Loading
  • Each Markdown needs one top-level heading (MD041)
  • Add missing language code for codeblocks
  • Add one blank line before/after a heading/list, per Markdownlint MD022 and MD032 rules
  • Unrelated but fix it to make CI happy: sort imports in dataclasses.py

Markdownlint rules: https://github.com/markdownlint/markdownlint/blob/main/docs/RULES.md

@bact
Fix a typo and Markdown heading levels
794d50a 
- Each Markdown needs one top-level heading (MD041)
- Add missing language code for codeblocks
- Add one blank line before/after a heading/list, per Markdownlint MD022 and MD032 rules

Markdownlint rules: https://github.com/markdownlint/markdownlint/blob/main/docs/RULES.md

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact requested a review from a team as a code owner January 29, 2025 13:44
@github-actions GitHub Actions
Copy link
github-actions bot commented Jan 29, 2025 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

bact added 4 commits January 29, 2025 13:50
@bact
Sort imports
9ba0888 
Fix CI errors

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact
Revert "Sort imports"
46f9a5e 
This reverts commit 9ba0888.
@bact
Sort imports according to isort in CI
cf12da5 
Give what it is expected

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact
Delete .DS_Store
0d33761 
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
benjelloun
benjelloun approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor
@benjelloun benjelloun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@ccl-core ccl-core merged commit ae4207f into mlcommons:main May 7, 2025
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2025
@bact bact deleted the fix-typos-markdown branch May 7, 2025 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjelloun benjelloun benjelloun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bact @benjelloun @ccl-core
0