Get manx working again #3160
Merged
Get manx working again #3160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uruwhy
requested changes
Apr 4, 2025
There was a problem hiding this comment.
https://github.com/daw1012345/caldera/blob/fix/manx_unusable/tests/contacts/test_contact_tcp.py#L16 needs to be replaced with session_with_socket_error.writer.write.side_effect = socket.error() in order for the unit tests to work again
elegantmoose
approved these changes
Apr 10, 2025
|
Nice work @daw1012345 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A set of fixes to get the tcp contact working again. Not that ideally this would be completely refactored, as it doesn't seem to handle disconnects very gracefully.
Depends on MR in mitre/manx to fully work.