8000 Update PyInstaller, add dev version info to builds. by mhils · Pull Request #2733 · mitmproxy/mitmproxy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update PyInstaller, add dev version info to builds. #2733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 30, 2017
Merged

Update PyInstaller, add dev version info to builds. #2733

merged 10 commits into from
Dec 30, 2017

Conversation

mhils
Copy link
Member
@mhils mhils commented Dec 29, 2017

If this works, we'll have mitmproxy on an actual PyInstaller release without too many further hacks! 🙌

@mhils
Copy link
Member Author
mhils commented Dec 29, 2017

There's still a small bug with the Windows builds I'll fix tomorrow, but the Linux release works fine 😅 . Can someone on OSX verify that https://snapshots.mitmproxy.org/v3.0.0/mitmproxy-3.0.0.dev1089-0xffaab2b-osx.tar.gz works?

@Kriechi
Copy link
Member
Kriechi commented Dec 30, 2017 •
edited
Loading

The link you provided is 404 now - so I used https://snapshots.mitmproxy.org/v3.0.0/mitmproxy-3.0.0dev1088-0x0b80fd0-osx.tar.gz.

All three tools start without errors.
{mitmproxy,mitmdump,mitmweb} --version shows:

Mitmproxy: 3.0.0 binary
Python:    3.5.3
OpenSSL:   OpenSSL 1.1.0f  25 May 2017
Platform:  Darwin-17.3.0-x86_64-i386-64bit

@Kriechi
Copy link
Member
Kriechi commented Dec 30, 2017

Also tested with the original link. Same positive result.
Although I sometimes see strange behaviour when Ctrl+C to quit:
(not sure if related to this PR or in general - but I can't remember seeing this before)

./mitmdump
Proxy server listening at http://[::]:8080
^C^CException ignored in: <module 'threading' from '/var/folders/th/v6q_2vkn41q60nghxrhjgncr0000gn/T/_MEIJgTgaI/threading.pyc'>
Traceback (most recent call last):
  File "threading.py", line 1288, in _shutdown
  File "threading.py", line 1054, in join
  File "threading.py", line 1070, in _wait_for_tstate_lock
KeyboardInterrupt

mhils added 3 commits December 30, 2017 18:48
@mhils
single-source version processing
9dc3d16
@mhils
fix appveyor build script
d15bdf8 
we now have a module named "types",
which of course confuses Python 3.5. O:-)
@mhils
fix #2470
6245566
@mhils mhils merged commit d9d4d15 into master Dec 30, 2017
@mhils mhils deleted the pyinstaller branch December 30, 2017 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhils @Kriechi
0