Fix mint compilation with Crystal version between 1.8.X & 1.10.X #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of crystal (>= 1.8.X) require an explicit import (And older version accept this import)
|
Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since crystal version 1.8.0, Digest::MD5 require an explicit import, so to allow compilation of mint with newer version of crystal i submit this PR with this import addition
This import doesn't break compatibility with current crystal version declared in shard.yml (Because we can use this import since version 0.21.0 of crystal)
Some precision : Atm we can compile project with newer version of crystal but any version between 1.8 & 1.11 (excluded) can't build mint due of this lack of import. Any version since 1.11 can compile without this explicit import because uuid of crystal import md5 explicitly (Cf here : crystal-lang/crystal@008d76a)
Cf :