10000 auto-detect python virtual environment by lorepap · Pull Request #1235 · mininet/mininet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

auto-detect python virtual environment #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

auto-detect python virtual environment #1235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 42 additions & 19 deletions util/install.sh
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a similar issue using mininet, I think this change definitely deserves a check.

10000
Original file line number Diff line number Diff line change
Expand Up @@ -102,26 +102,49 @@ function version_ge {
[ "$1" == "$latest" ]
}

# Attempt to detect Python version
PYTHON=${PYTHON:-python}
PRINTVERSION='import sys; print(sys.version_info)'
PYTHON_VERSION=unknown
for python in $PYTHON python2 python3; do
if $python -c "$PRINTVERSION" |& grep 'major=2'; then
PYTHON=$python; PYTHON_VERSION=2; PYPKG=python
break
elif $python -c "$PRINTVERSION" |& grep 'major=3'; then
PYTHON=$python; PYTHON_VERSION=3; PYPKG=python3
break
fi
done
if [ "$PYTHON_VERSION" == unknown ]; then
echo "Can't find a working python command ('$PYTHON' doesn't work.)"
echo "You may wish to export PYTHON or install a working 'python'."
exit 1
# Auto-detect python venv
if [ -n "$VIRTUAL_ENV" ]; then
# We are in a virtual environment; use its Python interpreter
PYTHON="${VIRTUAL_ENV}/bin/python"
echo "Using virtual environment Python interpreter at $PYTHON"

# Determine Python version in the virtual environment
PRINTVERSION='import sys; print(sys.version_info.major)'
PYTHON_VERSION=$($PYTHON -c "$PRINTVERSION")

if [ "$PYTHON_VERSION" == "2" ]; then
PYPKG=python
elif [ "$PYTHON_VERSION" == "3" ]; then
PYPKG=python3
else
echo "Unsupported Python version in virtual environment"
exit 1
fi
else
# Fall back to system Python if no virtual environment is detected
PYTHON=${PYTHON:-python}
echo "No virtual environment detected; using default Python at $(which $PYTHON)"
PRINTVERSION='import sys; print(sys.version_info)'
PYTHON_VERSION=unknown
for python in $PYTHON python2 python3; do
if $python -c "$PRINTVERSION" |& grep 'major=2'; then
PYTHON=$python; PYTHON_VERSION=2; PYPKG=python
break
elif $python -c "$PRINTVERSION" |& grep 'major=3'; then
PYTHON=$python; PYTHON_VERSION=3; PYPKG=python3
break
fi
done
if [ "$PYTHON_VERSION" == unknown ]; then
echo "Can't find a working python command ('$PYTHON' doesn't work.)"
echo "You may wish to export PYTHON or install a working 'python'."
exit 1
fi

echo "Detected Python (${PYTHON}) version ${PYTHON_VERSION}"
fi

echo "Detected Python (${PYTHON}) version ${PYTHON_VERSION}"


# Kernel Deb pkg to be removed:
KERNEL_IMAGE_OLD=linux-image-2.6.26-33-generic
Expand Down Expand Up @@ -203,7 +226,7 @@ function mn_deps {
sudo ${PYTHON} get-pip.py
rm get-pip.py
fi
${python} -m pip install pexpect
${PYTHON} -m pip install pexpect
$install iproute2 || $install iproute
$install cgroup-tools || $install cgroup-bin
$install cgroupfs-mount
Expand Down
0