8000 Physics update for mod interoperability with other mods and state changing sprint call by noobdigital87 · Pull Request #58 · minetest-mods/stamina · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Physics update for mod interoperability with other mods and state changing sprint call #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Physics update for mod interoperability with other mods and state changing sprint call #58

wants to merge 5 commits into from

Conversation

noobdigital87
Copy link
@noobdigital87 noobdigital87 commented Jun 7, 2025 •
edited
Loading
  • Instead of relying on hard values I added and removed the speed from the players definition speed to keep mod interoperability.
  • I also implemented state changing set_sprinting to avoid suppressing the physics.
  • Removed 3d_armor optional dependency from mod.conf since it is not needed to work

What does it do?

  1. It does not override other mods physics values so it will work together when wanted by modders
  2. It does not repeatedly call for stamina.set_sprint just 1x per state change
  3. You now no longer need 3d armor in your optional depends because the new physics code will adapt to what the player has

@noobdigital87 noobdigital87 changed the title Mod interoperability improved and avoided spamming set_sprinting Physics update for mod interoperability with other mods and state changing sprint call Jun 8, 2025
@SmallJoker
Copy link
Member
SmallJoker commented Jun 9, 2025 •
edited
Loading

Cross-reference to minetest-mods/3d_armor#164

It's not perfect. Please add a warning log upon startup to notify players and server owners when there's neither pova nor player_monoids enabled.

SmallJoker
SmallJoker reviewed Jun 9, 2025
View reviewed changes
@SmallJoker SmallJoker mentioned this pull request Jun 9, 2025
Closed
@noobdigital87
Copy link
Author
noobdigital87 commented Jun 9, 2025 •
edited
Loading

I agree it is not perfect but I think since there are no hard values the modder has more freedom to "adapt"
People should still use pova or monoids and I really get why I am just trying to have the physcis more open and still work without. With his limitations offcourse. But the limitations already existed anyways :)
I added the warning and the check for player:get_pos()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmallJoker SmallJoker SmallJoker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noobdigital87 @SmallJoker
0