8000 Simplify interfaces in RTEngine by evankanderson · Pull Request #5600 · mindersec/minder · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Simplify interfaces in RTEngine #5600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service 8000 and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2025
Merged

Simplify interfaces in RTEngine #5600

merged 2 commits into from
Apr 28, 2025

Conversation

evankanderson
Copy link
Member
@evankanderson evankanderson commented Apr 24, 2025 •
edited
Loading

Summary

I was looking at using github.com/mindersec/minder/pkg/engine in Scorecards, and I noticed a few places where the Minder code was more complex than necessary:

  • explicitly passing a flags.Interface where we already had functional options wired in
  • simplify project / organization naming
  • I added a rename of interfaces.Result to interfaces.Ingested because I always think of Result as an EvaluationResult...

Not addressed: NewRuleTypeEngine takes a varargs list of github.com/mindersec/minder/internal/engine/options, which can't be instantiated outside the project because they are in the internal branch. This includes DataSources, which seems important.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Checked unit tests for coverage on the changes.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner April 24, 2025 06:32
@evankanderson evankanderson merged commit d42f99e into mindersec:main Apr 28, 2025
25 checks passed
@evankanderson evankanderson deleted the simplify-rtengine branch April 28, 2025 16:50
@BrewTestBot BrewTestBot mentioned this pull request May 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdimitrov rdimitrov rdimitrov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evankanderson @rdimitrov
0