8000 ViTSTR disable pretrained backbone by default by felixdittrich92 · Pull Request #1080 · mindee/doctr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ViTSTR disable pretrained backbone by default #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2022
Merged

ViTSTR disable pretrained backbone by default #1080

merged 1 commit into from
Sep 29, 2022

Conversation

felixdittrich92
Copy link
Contributor
@felixdittrich92 felixdittrich92 commented Sep 29, 2022 •
edited
Loading

This PR:

  • disable using pretrained backbone in VITSTR by default
  • after some tests it runs much better without using the pretrained backbone

@felixdittrich92 felixdittrich92 changed the title disable pretrained backbone by default ViTSTR disable pretrained backbone by default Sep 29, 2022
@felixdittrich92 felixdittrich92 added this to the 0.6.0 milestone Sep 29, 2022
@felixdittrich92 felixdittrich92 added type: enhancement Improvement module: models Related to doctr.models framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend labels Sep 29, 2022
@felixdittrich92 felixdittrich92 self-assigned this Sep 29, 2022
@codecov
Copy link
codecov bot commented Sep 29, 2022

Codecov Report

Merging #1080 (04fa506) into main (ef4773e) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1080      +/-   ##
==========================================
- Coverage   95.23%   95.21%   -0.02%     
==========================================
  Files         142      142              
  Lines        6018     6018              
==========================================
- Hits         5731     5730       -1     
- Misses        287      288       +1
Flag Coverage Δ
unittests 95.21% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/recognition/vitstr/pytorch.py 97.46% <ø> (ø)
doctr/models/recognition/vitstr/tensorflow.py 97.56% <ø> (ø)
doctr/transforms/functional/base.py 95.65% <0.00%> (-1.45%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

charlesmindee
charlesmindee approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator
@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@felixdittrich92 felixdittrich92 merged commit dcbb21f into mindee:main Sep 29, 2022
@felixdittrich92 felixdittrich92 deleted the vitstr-pretrained branch September 29, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesmindee charlesmindee charlesmindee approved these changes

@odulcy-mindee odulcy-mindee Awaiting requested review from odulcy-mindee

Assignees

@felixdittrich92 felixdittrich92

Labels
framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend module: models Related to doctr.models type: enhancement Improvement
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@felixdittrich92 @charlesmindee
0