8000 [misc] Code quality fixes by felixT2K · Pull Request #1890 · mindee/doctr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[misc] Code quality fixes #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

[misc] Code quality fixes #1890

merged 2 commits into from
Mar 10, 2025

Conversation

felixT2K
Copy link
Contributor

This PR:

  • Fix mypy & style

@felixdittrich92 felixdittrich92 self-assigned this Mar 10, 2025
@felixdittrich92 felixdittrich92 added this to the 0.12.0 milestone Mar 10, 2025
@felixdittrich92 felixdittrich92 added type: misc Miscellaneous type: code quality Related to code quality module: models Related to doctr.models module: datasets Related to doctr.datasets and removed type: misc Miscellaneous labels Mar 10, 2025
@felixdittrich92 felixdittrich92 self-requested a review March 10, 2025 07:01
@codecov Codecov
Copy link
codecov bot commented Mar 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (5402948) to head (12ea793).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1890      +/-   ##
==========================================
+ Coverage   96.57%   96.59%   +0.02%     
==========================================
  Files         166      166              
  Lines        7991     7987       -4     
==========================================
- Hits         7717     7715       -2     
+ Misses        274      272       -2
Flag Coverage Δ
unittests 96.59% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@felixdittrich92 felixdittrich92 merged commit 3e21320 into mindee:main Mar 10, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixdittrich92 felixdittrich92 felixdittrich92 approved these changes

Assignees

@felixdittrich92 felixdittrich92

Labels
module: datasets Related to doctr.datasets module: models Related to doctr.models type: code quality Related to code quality
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@felixT2K @felixdittrich92
0