8000 [misc] post release v0.11.0 & public docker cron job adjustment by felixdittrich92 · Pull Request #1860 · mindee/doctr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[misc] post release v0.11.0 & public docker cron job adjustment #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

felixdittrich92
Copy link
Contributor
@felixdittrich92 felixdittrich92 commented Jan 30, 2025

This PR:

  • Apply post release changes
  • Adjust cronjob to avoid massive image registry overload
  • Docs are now built from torch backend

@felixdittrich92 felixdittrich92 self-assigned this Jan 30, 2025
@felixdittrich92 felixdittrich92 added this to the 0.12.0 milestone Jan 30, 2025
@felixdittrich92 felixdittrich92 added topic: build Related to dependencies and build topic: ci Related to CI topic: docker Docker-related type: misc Miscellaneous ext: docs Related to docs folder labels Jan 30, 2025
@@ -9,7 +9,7 @@ on:
pull_request:
branches: main
schedule:
- cron: '0 2 29 * *' # At 02:00 on day-of-month 29
- cron: '0 2 1 */3 *' # At 02:00 on the 1st day of every 3rd month
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odulcy-mindee adjusted a bit we have already 200+ images in the registry I think every month + releases was to much 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, ok, that's fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad to see it works again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah :D

8000
@felixdittrich92 felixdittrich92 marked this pull request as ready for review January 30, 2025 10:07
@@ -27,7 +27,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -e .[tf,viz,html] --upgrade
pip install -e .[torch,viz,html] --upgrade
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs are now also finally built with torch backend :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

odulcy-mindee
odulcy-mindee previously approved these changes Jan 30, 2025
@felixdittrich92
Copy link
Contributor Author
felixdittrich92 commented Jan 30, 2025

@odulcy-mindee small typo in changelog 😅

Copy link
Contributor
@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brent_rambo

@felixdittrich92 felixdittrich92 merged commit b84bb84 into mindee:main Jan 30, 2025
68 checks passed
Copy link
codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (1c9ce92) to head (7128838).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1860      +/-   ##
==========================================
+ Coverage   96.54%   96.62%   +0.07%     
==========================================
  Files         165      165              
  Lines        7941     7941              
==========================================
+ Hits         7667     7673       +6     
+ Misses        274      268       -6     
Flag Coverage Δ
unittests 96.62% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 deleted the post-release branch January 30, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: docs Related to docs folder topic: build Related to dependencies and build topic: ci Related to CI topic: docker Docker-related type: misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0