8000 [DNM] Rewind bad block (#3600) by antiochp · Pull Request #3602 · mimblewimble/grin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[DNM] Rewind bad block (#3600) #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DNM] Rewind bad block (#3600) #3602

wants to merge 1 commit into from

Conversation

antiochp
Copy link
Member
@antiochp antiochp commented Mar 18, 2021 •
edited
Loading

Do not merge.

We don't actually want this on master.
We want to decide on the correct long-term approach and implement that here.

  • Currently the rangeproof verification cache is disabled on both master and 5.0.x branches.
    • We need to decide if we want to reintroduce this fully and what the cache key impl needs to be.
  • "rewind bad block" should not be required on master as it was simply a hot fix to get past the "bad fork"
  • We do want to propagate the InvalidBlockProof error (to ban peers correctly)
    • the whole error/bool/ban logic needs a rethink and cleanup as its hard to reason about currently
  • Related [5.0.x] rewind bad headers, ban on explicit bad headers #3603 (on 5.0.x branch) "rewind headers and ban"
    • "rewind headers" also a hot fix and not required on master
  • but we do need to handle the "good header, bad block" scenario robustly somehow and this needs impl on master
    • one option is explicit list of "bad headers" as we have in that PR but ideally this is dynamic

I'll open a tracking issue for all of above and we can close this PR once its tracked elsewhere.

Cherry-picked #3600 from current/5.0.x

  • rewind prior to known bad block on chain init
  • rewind prior to bad block if found on current chain
  • pass InvalidBlockProof through

@antiochp
[5.0.x] Rewind bad block (mimblewimble#3600)
d33f060 
* rewind prior to known bad block on chain init

* rewind prior to bad block if found on current chain

* pass InvalidBlockProof through
@antiochp antiochp changed the title Rewind bad block (#3600) [DNM] Rewind bad block (#3600) Mar 19, 2021
@antiochp
Copy link
Member Author

Tracking issue - #3605

Closing this PR.

@antiochp antiochp closed this Mar 19, 2021
@antiochp antiochp mentioned this pull request May 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@antiochp
0