Refactor prune file replace #3571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only one needs a mut ref to self
bayk
added a commit
to mwcproject/mwc-node
that referenced
this pull request
Jun 12, 2024
* split prune file rewrite into two steps only one needs a mut ref to self * write both tmp files then replace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a smaller refactor based on #3568.
We now write the tmp hash file and the tmp data file during chain compaction and then replace both underlying files with the tmp files.
Writing the tmp files does not require
&mut selfand this mut reference is only necessary in the final replace step.Writing the tmp files can now be done with a simple
&selfreference which makes the code more flexible.Still testing these changes but as far as I can tell this does not reintroduce the issue in #3568 (reverted in #3569).