8000 [skip ci] Add comments for parse bool node by cydrain · Pull Request #8552 · milvus-io/milvus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[skip ci] Add comments for parse bool node #8552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2021
Merged

[skip ci] Add comments for parse bool node #8552

merged 1 commit into from
Sep 27, 2021

Conversation

cydrain
Copy link
Contributor
@cydrain cydrain commented Sep 26, 2021

Signed-off-by: yudong.cai yudong.cai@zilliz.com

@cydrain
Copy link
Contributor Author
cydrain commented Sep 26, 2021

/kind improvement

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/S Denotes a PR that changes 10-29 lines. labels Sep 26, 2021
@cydrain
Copy link
Contributor Author
cydrain commented Sep 26, 2021

/hold

@codecov
Copy link
codecov bot commented Sep 26, 2021 •
edited
Loading

Codecov Report

Merging #8552 (762f57f) into master (a20a9c7) will decrease coverage by 0.41%.
The diff coverage is 100.00%.

❗ Current head 762f57f differs from pull request most recent head d13b759. Consider uploading reports for the commit d13b759 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8552      +/-   ##
==========================================
- Coverage   78.58%   78.16%   -0.42%     
==========================================
  Files         252      252              
  Lines       44904    44895       -9     
==========================================
- Hits        35289    35094     -195     
- Misses       7464     7667     +203     
+ Partials     2151     2134      -17
Impa 8000 cted Files Coverage Δ
internal/proxy/plan_parser.go 79.43% <100.00%> (-0.19%) ⬇️
internal/proxy/task_scheduler.go 54.45% <0.00%> (-28.04%) ⬇️
internal/indexnode/indexnode_mock.go 86.31% <0.00%> (-5.27%) ⬇️
internal/querycoord/task.go 70.09% <0.00%> (-4.95%) ⬇️
internal/querynode/flow_graph_filter_dm_node.go 93.07% <0.00%> (-3.85%) ⬇️
...nternal/util/rocksmq/client/rocksmq/client_impl.go 87.50% <0.00%> (-3.85%) ⬇️
internal/querynode/flow_graph_insert_node.go 85.71% <0.00%> (-3.58%) ⬇️
internal/proxy/channels_mgr.go 79.61% <0.00%> (-3.19%) ⬇️
internal/proxy/meta_cache.go 76.89% <0.00%> (-3.04%) ⬇️
internal/querynode/plan.go 80.82% <0.00%> (-2.74%) ⬇️
... and 25 more

@mergify mergify bot added the ci-passed label Sep 26, 2021
@wxyucs
Copy link
Member
wxyucs commented Sep 26, 2021

/cc @fishpenguin

@cydrain
[skip ci] Add comments for parse bool node
d13b759 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain cydrain force-pushed the caiyd_optimize_parse_bool branch from 762f57f to d13b759 Compare September 26, 2021 06:38
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. and removed lgtm size/S Denotes a PR that changes 10-29 lines. labels Sep 26, 2021
@wxyucs
Copy link
Member
wxyucs commented Sep 26, 2021

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain, scsven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wxyucs wxyucs changed the title Optimize parse bool node [skip ci] Add comments for parse bool node Sep 26, 2021
@czs007
Copy link
Collaborator
czs007 commented Sep 27, 2021

/unhold

@sre-ci-robot sre-ci-robot merged commit 97451ba into milvus-io:master Sep 27, 2021
@cydrain cydrain deleted the caiyd_optimize_parse_bool branch September 28, 2021 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@fishpenguin fishpenguin Awaiting requested review from fishpenguin

Assignees

@wxyucs wxyucs

@fishpenguin fishpenguin

Labels
approved ci-passed kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cydrain @wxyucs @sre-ci-robot @czs007 @fishpenguin
0