8000 Optimize proxy query execute by cydrain · Pull Request #8479 · milvus-io/milvus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Optimize proxy query execute #8479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2021
Merged

Optimize proxy query execute #8479

merged 1 commit into from
Sep 24, 2021

Conversation

cydrain
Copy link
Contributor
@cydrain cydrain commented Sep 24, 2021

Signed-off-by: yudong.cai yudong.cai@zilliz.com

@cydrain
Optimize proxy query execute
dc86824 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain
Copy link
Contributor Author
cydrain commented Sep 24, 2021

/kind improvement

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/S Denotes a PR that changes 10-29 lines. labels Sep 24, 2021
@cydrain
Copy link
Contributor Author
cydrain commented Sep 24, 2021

/hold

@codecov
Copy link
codecov bot commented Sep 24, 2021

Codecov Report

Merging #8479 (dc86824) into master (d283419) will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8479      +/-   ##
==========================================
+ Coverage   78.02%   78.03%   +0.01%     
==========================================
  Files         251      251              
  Lines       32980    32976       -4     
==========================================
+ Hits        25731    25733       +2     
- Misses       5138     5148      +10     
+ Partials     2111     2095      -16
Impacted Files Coverage Δ
internal/proxy/task.go 74.82% <33.33%> (+0.08%) ⬆️
internal/querycoord/task.go 70.20% <0.00%> (-4.66%) ⬇️
internal/distributed/indexnode/client/client.go 59.20% <0.00%> (-1.60%) ⬇️
internal/proxy/segment.go 88.38% <0.00%> (-1.52%) ⬇️
internal/querycoord/meta.go 61.98% <0.00%> (-0.88%) ⬇️
internal/rootcoord/task.go 82.70% <0.00%> (-0.37%) ⬇️
...ternal/util/rocksmq/server/rocksmq/rocksmq_impl.go 75.48% <0.00%> (+0.48%) ⬆️
internal/indexcoord/index_coord.go 78.87% <0.00%> (+0.62%) ⬆️
internal/querycoord/querynode.go 66.13% <0.00%> (+0.79%) ⬆️
... and 10 more

@longjiquan
Copy link
Contributor

/lgtm

@wxyucs
Copy link
Member
wxyucs commented Sep 24, 2021

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain, scsven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cydrain
Copy link
Contributor Author
cydrain commented Sep 24, 2021

/unhold

@sre-ci-robot sre-ci-robot merged commit 3938d68 into milvus-io:master Sep 24, 2021
@cydrain cydrain deleted the caiyd_update_proxy_query_prexecute branch September 24, 2021 16:22
xiyichan pushed a commit to xiyichan/milvus that referenced this pull request Sep 26, 2021
@cydrain @xiyichan
Optimize proxy query execute (milvus-io#8479)
a6fdc4f 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FluorineDog FluorineDog Awaiting requested review from FluorineDog

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@longjiquan longjiquan

Labels
approved ci-passed kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cydrain @longjiquan @wxyucs @sre-ci-robot @yanliang567
0