Tqdm implementation #205
Merged
Tqdm implementation #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edugzlez Thanks for contributing this feature to pysmb! I will review this over the festive weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After diligently utilizing the impressive pysmb library for several months, it became apparent that a lack of information regarding the progress of file downloads and uploads was causing significant inconvenience. As a result, I made the decision to implement a solution for the benefit of all programmers.
TQDM: A Fantastic Library for Progress Bars
TQDM is a fantastic library provided by the community that allows us to easily incorporate a fully customizable progress bar into our projects. I have included the
show_progressandtqdm_kwargsparameters in theretrieveFileandstoreFilemethods, withshow_progressset toFalseby default (though it is highly unlikely that anyone would choose to leave it this way).Any suggestions for changes or improvements are welcome.
I would like to extend my gratitude to my colleague @akovalde98 for their assistance.