Remove DataIndication Queuing from Kernel Datapath #5091
+51
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
commented
May 10, 2025
| // | ||
| // Release any dropped or copied datagrams. | ||
| // | ||
| Binding->DgrmSocket->Dispatch->WskRelease(Binding->Socket, DataIndicationHead); |
There was a problem hiding this comment.
Should/can we just return STATUS_SUCCESS at the end to indicate inline processing and then not call WskRelease at all?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5091 +/- ##
==========================================
- Coverage 87.00% 85.77% -1.24%
==========================================
Files 59 59
Lines 18035 18035
==========================================
- Hits 15692 15469 -223
- Misses 2343 2566 +223 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For several years now, the Windows kernel datapath has been always copying the recevied data in to local buffers because we found that any significant queuing can cause problems lower in the stack (i.e., the NIC); even if we queued only 1 indication. So, let's just remove all the code that supported the queuing mode to eliminate unnecessary branches in the kernel datapath code.
Testing
CI/CD
Documentation
N/A