8000 Receive buffer simplication [4/4] by guhetier · Pull Request #5079 · microsoft/msquic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Receive buffer simplication [4/4] #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Receive buffer simplication [4/4] #5079

wants to merge 4 commits into from

Conversation

guhetier
Copy link
Contributor
@guhetier guhetier commented May 6, 2025

Description

  • Simplify the logic around the receive buffer growth logic
    • Remove code duplication and simplify control flow
  • Simplify logic around the pre-allocated chunk memory management
    • The receive buffer now own the chunk. The refactoring of pools makes it possible to deallocate it easily.

Testing

CI

Documentation

Already covered by existing documentation, comments updated.

@guhetier guhetier self-assigned this May 6, 2025
@guhetier guhetier added the Area: Core Related to the shared, core protocol logic label May 6, 2025
@codecov Codecov
Copy link
codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 84.84848% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.91%. Comparing base (00bfb1e) to head (48a8969).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/core/recv_buffer.c 84.84% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5079      +/-   ##
==========================================
- Coverage   87.11%   85.91%   -1.21%     
==========================================
  Files          59       59              
  Lines       17924    17973      +49     
==========================================
- Hits        15615    15441     -174     
- Misses       2309     2532     +223

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@guhetier guhetier

Labels
Area: Core Related to the shared, core protocol logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@guhetier
0