Detect AOF History Divergence with No Checkpoint #1263
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds new tests for AOF history divergence scenarios when no checkpoint is taken and adjusts related cluster replication and configuration logic. Key changes include new tests for multi-restart recovery and history divergence without checkpoint, updates to logging and comments in replication management, and enhancements to cluster configuration formatting.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/Garnet.test.cluster/ReplicationTests/ClusterReplicationBaseTests.cs | Added tests for multi-restart recovery and history divergence without checkpoint; updated test order attributes. |
| test/Garnet.test.cluster/ClusterTestUtils.cs | Added a new WaitForPrimaryRole method. |
| libs/cluster/Session/RespClusterBasicCommands.cs | Updated call to GetShardsInfo to include a cluster connection parameter. |
| libs/cluster/Server/Replication/ReplicationManager.cs | Updated comment to reflect change from TryConnectToPrimary to TryReplicate. |
| libs/cluster/Server/Replication/PrimaryOps/ReplicaSyncSession.cs | Enhanced checkpoint logic to determine when to replay AOF from the beginning. |
| libs/cluster/Server/ClusterConfig.cs | Modified cluster config formatting to include connection status and improved documentation. |
test/Garnet.test.cluster/ReplicationTests/ClusterReplicationBaseTests.cs
Show resolved
Hide resolved
d3d6cd6 to
f8d7b0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for history divergence when no checkpoint is taken.
In that case, we need to replay AOF from BeginAddress to ensure replica does not diverge