Fix BDN and Nightly Pipeline issues #1232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the nightly pipeline resource issues by updating the scheduled runtime to 1:00 AM PST, and it also revises benchmark configuration values in the JSON.Operations tests to match the current expected outcomes.
- Adjust the nightly test schedule in the GitHub workflow.
- Update benchmark values in BDN_Benchmark_Config.json for various JSON operation tests.
- Specifically, update values for GetDeepPath, GetFilterPath, and SScan operations.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/BDNPerfTests/BDN_Benchmark_Config.json | Updated several expected benchmark values to align with new tests. |
| .github/workflows/nightly.yml | Adjusted the cron schedule to trigger tests at 1:00 AM PST. |
Comments suppressed due to low confidence (2)
test/BDNPerfTests/BDN_Benchmark_Config.json:362
- Ensure that the updated benchmark value for expected_ModuleJsonGetCommand_ACL is validated against current performance data to maintain consistency across tests.
"expected_ModuleJsonGetCommand_ACL": 360000,
test/BDNPerfTests/BDN_Benchmark_Config.json:445
- The increase in expected_SScan_None is significantly higher than previous values; please confirm that this change accurately reflects updated performance metrics.
"expected_SScan_None": 72000,
badrishc
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nightly pipeline has been having issues where resources are short when ran at night. Not sure if it is the specific time (11:00PM) that it is running at so adjusting to 1:00am run time now.
Also, updating some of the JSON.Operations BDN values to match the current expected. Most of changes were in the GetDeepPath and GetFilterPath tests.