Minimal version deprecation change #252293
Open
+61
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverted the refactoring that split the null check into two separate if statements. The change was non-functional - both approaches are equivalent.
Reverted the addition of explicit type annotation (setting: string) that was added in the previous commit.
Reverted the addition of the onChange listener that was updating extension enablement state when extensions were installed/uninstalled/updated. Also removed the IExtensionsWorkbenchService dependency.
Only removed the onChange listener that was added for updating extension enablement on install/uninstall/update events. Kept the service dependency as it's used elsewhere in the class.
- Combined isExtensionDeprecated check with ternary operator to use 'deprecated' variable name - Removed unnecessary comment - Kept template string unchanged
Removed two onChange listeners that were re-rendering widgets on extension changes.
- Removed unused service injections from two widget constructors - Removed extra blank line in extensionsList.ts
|
Tested extensively locally. |
- Remove unnecessary intermediate variable - Directly use semver.lte() in conditional check - Keep duplication minimal between files for clarity 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
igorkofman
commented
Jun 24, 2025
| @@ -53,7 +61,7 @@ export async function migrateUnsupportedExtensions(extensionManagementService: I | |||
|
|
|||
| let preReleaseExtension = installed.find(i => areSameExtensions(i.identifier, { id: preReleaseExtensionId })); | |||
| if (!preReleaseExtension || (!preReleaseExtension.isPreReleaseVersion && isUnsupportedExtensionEnabled)) { | |||
| preReleaseExtension = await extensionManagementService.installFromGallery(gallery, { installPreReleaseVersion: true, isMachineScoped: unsupportedExtension.isMachineScoped, operation: InstallOperation.Migrate, context: { [EXTENSION_INSTALL_SKIP_PUBLISHER_TRUST_CONTEXT]: true } }); | |||
| preReleaseExtension = await extensionManagementService.installFromGallery(gallery, { installPreReleaseVersion: preRelease, isMachineScoped: unsupportedExtension.isMachineScoped, operation: InstallOperation.Migrate, context: { [EXTENSION_INSTALL_SKIP_PUBLISHER_TRUST_CONTEXT]: true } }); | |||
There was a problem hiding this comment.
I believe this is potentially a bug in the existing implementation as it results in a "pre-release" badge on the extension. Ok skipping this but seems correct to include.
|
@microsoft-github-policy-service agree company="Anthropic" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for deprecating specific version of extensions. To test, serve a deprecation manifest which has a deprecatedVersion set. Any versions of the extension at or below the deprecatedVersion will be marked deprecated.