8000 cache builtin commands for shells to decrease terminal completion latency by meganrogge · Pull Request #252232 · microsoft/vscode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cache builtin commands for shells to decrease terminal completion latency #252232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2025

Conversation

meganrogge
Copy link
Contributor
@meganrogge meganrogge commented Jun 23, 2025

To isolate the improvement, I first requested completions in a shell other than the target shell to discard the extension activation timing and to obtain a baseline. I then requested completions in the shell of interest and recorded the latency. After reloading the window, I repeated the process - first requesting completions in a non-target shell, then in the shell of interest - tracking the latency again.

Reduces latency by 2432ms for bash (90%), 460ms for pwsh (64%), and 661ms on zsh (79%).

Before:
after requesting completions in pwsh, requesting completions in bash
Screenshot 2025-06-23 at 4 50 46 PM

after reloading the window and after requesting completions in pwsh, requesting completions in bash
Screenshot 2025-06-23 at 4 51 22 PM

After:
after requesting completions in pwsh, requesting completions in bash
Screenshot 2025-06-23 at 4 46 49 PM

after reloading the window and after requesti 8000 ng completions in pwsh, requesting completions in bash
Screenshot 2025-06-23 at 4 47 49 PM

Opposite, but for pwsh

Before:
Screenshot 2025-06-23 at 4 55 57 PM
Reload
Screenshot 2025-06-23 at 4 58 07 PM

After:
Screenshot 2025-06-23 at 4 58 51 PM
Reload
Screenshot 2025-06-23 at 4 59 11 PM

Same, but for zsh

Before:
Screenshot 2025-06-23 at 5 02 07 PM
Reload
Screenshot 2025-06-23 at 5 02 24 PM

After:
Screenshot 2025-06-23 at 5 00 37 PM
Reload
Screenshot 2025-06-23 at 5 00 57 PM

Part of #251994

@meganrogge meganrogge self-assigned this Jun 23, 2025
@vs-code-engineering vs-code-engineering bot added this to the June 2025 milestone Jun 23, 2025
@meganrogge meganrogge requested a review from Tyriar June 23, 2025 21:07
@meganrogge meganrogge merged commit 2e763a8 into main Jun 23, 2025
8 checks passed
@meganrogge meganrogge deleted the merogge/perf branch June 23, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
< 3993 input type="hidden" name="_method" value="put" autocomplete="off" />
Development

Successfully merging this pull request may close these issues.

2 participants
0