10000 fix terminal suggest light+ contrast issue for partial item by meganrogge · Pull Request #251940 · microsoft/vscode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

fix terminal suggest light+ contrast issue for partial item #251940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025
+2 −2
Merged

fix terminal suggest light+ contrast issue for partial item #251940

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b61289
fix #251932
meganrogge Jun 19, 2025
eb8d289
apply regardless of theme
meganrogge Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/vs/workbench/services/suggest/browser/simpleSuggestWidget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import { status } from '../../../../base/browser/ui/aria/aria.js';
import { isWindows } from '../../../../base/common/platform.js';
import { editorSuggestWidgetSelectedBackground } from '../../../../editor/contrib/suggest/browser/suggestWidget.js';
import { getListStyles } from '../../../../platform/theme/browser/defaultStyles.js';
import { activeContrastBorder, focusBorder } from '../../../../platform/theme/common/colorRegistry.js';
import { activeContrastBorder, focusBorder, listFocusForeground } from '../../../../platform/theme/common/colorRegistry.js';

const $ = dom.$;

Expand Down Expand Up @@ -930,7 +930,7 @@ export class SimpleSuggestWidget<TModel extends SimpleCompletionModel<TItem>, TI

function getListStylesWithMode(partial?: boolean): IListStyles {
if (partial) {
return getListStyles({ listInactiveFocusOutline: focusBorder });
return getListStyles({ listInactiveFocusOutline: focusBorder, listInactiveFocusForeground: listFocusForeground });
} else {
return getListStyles({ listInactiveFocusBackground: editorSuggestWidgetSelectedBackground, listInactiveFocusOutline: activeContrastBorder });
}
Expand Down
Loading
0