8000 Ensure tab doesn't get stuck in tool confirmation code block by meganrogge · Pull Request #249138 · microsoft/vscode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ensure tab doesn't get stuck in tool confirmation code block #249138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files. < 8000 /div>
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/editor/browser/config/editorConfiguration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export class EditorConfiguration extends Disposable implements IEditorConfigurat
lineNumbersDigitCount: this._lineNumbersDigitCount,
emptySelectionClipboard: partialEnv.emptySelectionClipboard,
pixelRatio: partialEnv.pixelRatio,
tabFocusMode: TabFocus.getTabFocusMode(),
tabFocusMode: this._validatedOptions.get(EditorOption.tabFocusMode) || TabFocus.getTabFocusMode(),
inputMode: InputMode.getInputMode(),
accessibilitySupport: partialEnv.accessibilitySupport,
glyphMarginDecorationLaneCount: this._glyphMarginDecorationLaneCount,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2164,7 +2164,7 @@ class EditorContextKeysManager extends Disposable {
private _updateFromConfig(): void {
const options = this._editor.getOptions();

this._tabMovesFocus.set(TabFocus.getTabFocusMode());
this._tabMovesFocus.set(options.get(EditorOption.tabFocusMode) || TabFocus.getTabFocusMode());
this._editorReadonly.set(options.get(EditorOption.readOnly));
this._inDiffEditor.set(options.get(EditorOption.inDiffEditor));
this._editorColumnSelection.set(options.get(EditorOption.columnSelection));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ export class TerminalConfirmationWidgetSubPart extends BaseChatToolInvocationSub
verticalPadding: 5,
editorOptions: {
wordWrap: 'on',
readOnly: false
readOnly: false,
tabFocusMode: true
}
};
const langId = this.languageService.getLanguageIdByLanguageName(terminalData.language ?? 'sh') ?? 'shellscript';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ export class ToolConfirmationSubPart extends BaseChatToolInvocationSubPart {
reserveWidth: 19,
verticalPadding: 5,
editorOptions: {
wordWrap: 'on'
wordWrap: 'on',
tabFocusMode: true
}
};

Expand Down Expand Up @@ -224,6 +225,7 @@ export class ToolConfirmationSubPart extends BaseChatToolInvocationSubPart {
try {
const parsed = JSON.parse(model.getValue());
model.setValue(JSON.stringify(parsed, null, 2));
editor.object.editor.updateOptions({ tabFocusMode: false });
editor.object.editor.updateOptions({ wordWrap: 'on' });
} catch {
// ignored
Expand Down
1 change: 1 addition & 0 deletions src/vs/workbench/contrib/chat/browser/codeBlockPart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ export class CodeBlockPart extends Disposable {
},
ariaLabel: localize('chat.codeBlockHelp', 'Code block'),
overflowWidgetsDomNode,
tabFocusMode: true,
...this.getEditorOptionsFromConfig(),
});

Expand Down
Loading
0