Initial support of dynamic auth providers for MCP #249501
Merged
+1,163
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, we support being able to on-the-fly create an Auth Provider based on an oauth-authorization-server's metadata. MCP then leverages this because by following the MCP spec we can figure out the oauth server metadata and then request a token from that server. The tokens are persisted and will be refreshed on demand... all based on the OAuth spec.
connor4312
reviewed
May 22, 2025
connor4312
reviewed
May 22, 2025
connor4312
approved these changes
May 22, 2025
|
Hi @TylerLeonhardt, I am contacting you to share some feedback if you don't mind.
Any idea what could be the issue? Thanks |
|
@lkchao-majority can you open these as two new issues and we'll work through them? Please provide the platform you're on and what you're MCP config looks like in VS Code.
|
jeanp413
reviewed
May 26, 2025
Comment on lines
+114
to
+116
| if (isDisposable(provider)) { | ||
| provider.dispose(); | ||
| } |
There was a problem hiding this comment.
@TylerLeonhardt this is causing a Maximum call stack size exceeded error in the extension host, from the github authentication extension when running vscode in the browser, the extension should be responsible of disposing any of its resources rather than vscode doing it
There was a problem hiding this comment.
Nice catch, I've removed that in #249845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we support being able to on-the-fly create an Auth Provider based on an oauth-authorization-server's metadata.
MCP then leverages this because by following the MCP spec we can figure out the oauth server metadata and then request a token from that server.
The tokens are persisted and will be refreshed on demand... all based on the OAuth spec.
Fixes #247759