244332 - This is for a bug I rased about Rdp and multiple sessions #247528
Conversation
|
This is for the issue I raised a bit ago: #244332 |
If you 1) log into two sessions with the same user 2) launch vs code from the command line in session 1 3) launch vs code from the command line in session 2 The second instance starts in the first session. I assume this can't ben the intended behavior as it's weird to launch an app in a place you won't see it. This fix scopes the named pipe to include the name of the session, which is unique to that specific session, regardless of user.
|
@joyceerhl is there any other action required on my end for this? |
|
I think this is not the right fix: the socket needs to stay symmetric with all other folders for the instance (specifically user data path), otherwise we risk that 2 separate instances open over the same user data dir, that is actually what we try to prevent here. |
|
@bpasero thanks for the feedback. I was worried it felt too easy. |
|
I believe this cannot be easily fixed automatically because it might make the wrong assumptions for users that only use 1 session. Have you considered a portable setup? See https://code.visualstudio.com/docs/editor/portable |
|
@bpasero - Thanks for the suggestion. I downloaded vscode portable and tried to repro, however it still does the same "wrong session launch" behavior. I think I may be confused though. I don't follow how this could break single session functionality. In the case of the single session, the session name will be consistent. I have tested that scenario and it continues to work as expected. |
If you
The second instance starts in the first session.
I assume this can't be the intended behavior as it's weird to launch an app in a place you won't see it.
This fix scopes the named pipe to include the name of the session, which is unique to that specific session, regardless of user.