8000 Fixed Issue #110225 - Dragging to select text on Peek window should not hide it by myovan · Pull Request #112384 · microsoft/vscode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Issue #110225 - Dragging to select text on Peek window should not hide it #112384

Merged
merged 3 commits into from
Dec 18, 2020
Merged

Fixed Issue #110225 - Dragging to select text on Peek window should not hide it #112384

merged 3 commits into from
Dec 18, 2020

Conversation

myovan
Copy link
Contributor
@myovan myovan commented Dec 13, 2020

This PR fixes #110225

Fixes issue where attempting to drag to select text on Hover widget prematurely closes Hover immediately. Allows for users to drag and select text within hover and move outside it, without it closing.

With the newly implemented change, dragging outside does not close the popup like in the above visual.

@alexdima alexdima added this to the January 2021 milestone Dec 18, 2020
@alexdima
Copy link
Member

Thank you!

@alexdima alexdima merged commit 54dc2d7 into microsoft:master Dec 18, 2020
@Honga1
Copy link
Honga1 commented Dec 20, 2020

@alexdima Thank you :).

@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@alexdima alexdima

Labels
None yet
Projects
None yet
Milestone
January 2021
Development

Successfully merging this pull request may close these issues.

Dragging to select text on Peek window should not hide it
3 participants
@myovan @alexdima @Honga1
0