fix: Param helper hover getting cut off at bottom #112019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rheh
reviewed
Dec 7, 2020
| asyncRenderCallback: () => { | ||
| this.domNodes?.scrollbar.scanDomNode(); | ||
| } | ||
| })); |
There was a problem hiding this comment.
This line and the lines surrounding lines are a duplicate of line 228-232. Other than the dom element target (documentation or dom variable). Should we refactor to bring these into the same place e.g.
if (typeof signature.documentation === 'string') {
dom.append(this.domNodes.docs, $('p', {}, signature.documentation));
} else {
const renderedContents = this.renderDisposeables.add(this.markdownRenderer.render(signature.documentation));
const renderedContents = this.renderDisposeables.add(this.markdownRenderer.render(signature.documentation, {
asyncRenderCallback: () => {
this.domNodes?.scrollbar.scanDomNode();
}
}));
renderedContents.element.classList.add('markdown-docs');
const target = activeParameter?.documentation ?? dom;
target.append(this.domNodes.docs, renderedContents.element);
There was a problem hiding this comment.
just like this?
private renderMarkdownDocs(markdown: IMarkdownString | undefined): IMarkdownRenderResult {
const renderedContents = this.renderDisposeables.add(this.markdownRenderer.render(markdown, {
asyncRenderCallback: () => {
this.domNodes?.scrollbar.scanDomNode();
}
}));
renderedContents.element.classList.add('markdown-docs');
return renderedContents;
}3a28190 to
b2d1228
Compare
|
@joaomoreno Can you help take a look at this PR |
|
Thanks! Should be available in the first VS Code 1.53 insiders builds |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #105422