8000 Tasks without command are added to instances by alexr00 · Pull Request #92866 · microsoft/vscode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Tasks without command are added to instances #92866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2020
Merged

Tasks without command are added to instances #92866

merged 1 commit into from
Mar 17, 2020

Conversation

alexr00
Copy link
Member
@alexr00 alexr00 commented Mar 17, 2020

Fixes #92792

8000
@alexr00 alexr00 added this to the February 2020 Recovery milestone Mar 17, 2020
@alexr00 alexr00 self-assigned this Mar 17, 2020
@isidorn
Copy link
Contributor
isidorn commented Mar 17, 2020

The gist of the change is that the tasks without commands are no longer tracked in instances. I do not really know for what the instances array is excatly used.
There is also an extraction of check to a method.
Overall the code changes seem ok. Now I am just verifying that this indeed fixes the issue.

@isidorn
Copy link
Contributor
isidorn commented Mar 17, 2020

Adding approved since the code looks good.
However it would be great if @Tyriar or @dbaeumer also review since they know the code better.

Tyriar
Tyriar approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member
@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexr00 a detailed description of the fix in the commit for candidates would be handy next time 🙂

It looks like the instance was being overridden incorrectly by an empty task (don't have insight into what this is) which ends up breaking the link to the real instance and therefore can no longer track its status.
@Tyriar Tyriar merged commit fe22a96 into release/1.43 Mar 17, 2020
@Tyriar Tyriar deleted the alexr00/issue92792 branch March 17, 2020 23:49
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@isidorn isidorn isidorn approved these changes

@Tyriar Tyriar Tyriar approved these changes

Assignees

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
February 2020 Recovery
Development

Successfully merging this pull request may close these issues.
3 participants
@alexr00 @isidorn @Tyriar
0